Bug 235907

Summary: null ptr deref in LayoutIntegrationLineLayout LineLayout::adjustForPagination and LineLayout::visualOverflowBoundingBoxRectFor
Product: WebKit Reporter: Gabriel Nava Marino <gnavamarino>
Component: Layout and RenderingAssignee: Gabriel Nava Marino <gnavamarino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Gabriel Nava Marino
Reported 2022-01-31 12:41:20 PST
m_inlineContent could become null (such as after calling LineLayout::clearInlineContent(), so we add these two checks to protect against an nullptr deref. <rdar://problem/88265059>
Attachments
Patch (4.68 KB, patch)
2022-01-31 12:48 PST, Gabriel Nava Marino 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabriel Nava Marino
Comment 1 2022-01-31 12:48:16 PST
Created attachment 450432 [details] Patch
Gabriel Nava Marino
Comment 2 2022-02-01 09:40:58 PST
Comment on attachment 450432 [details] Patch The layout test failures on win are appearing in the WebKit Results Database history in past revisions are unrelated to this patch.
EWS
Comment 3 2022-02-01 10:20:12 PST
Committed r288891 (246638@main): <https://commits.webkit.org/246638@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450432 [details].
Note You need to log in before you can comment on or make changes to this bug.