Bug 235892

Summary: [WP] Remove PostScript conversion code
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ddkilzer, ews-watchlist, japhet, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 3527    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
thorton: review+
Patch none

Per Arne Vollan
Reported 2022-01-31 08:05:02 PST
The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
Attachments
Patch (2.69 KB, patch)
2022-01-31 08:07 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (6.85 KB, patch)
2022-01-31 15:59 PST, Per Arne Vollan 		thorton: review+
DetailsFormatted DiffDiff
Patch (6.90 KB, patch)
2022-02-01 11:05 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-01-31 08:05:28 PST
<rdar://88172449>
Per Arne Vollan
Comment 2 2022-01-31 08:07:16 PST
Created attachment 450411 [details] Patch
Brent Fulgham
Comment 3 2022-01-31 09:53:55 PST
Comment on attachment 450411 [details] Patch r=me
Per Arne Vollan
Comment 4 2022-01-31 11:02:57 PST
Comment on attachment 450411 [details] Patch Thanks for reviewing!
EWS
Comment 5 2022-01-31 11:37:41 PST
Committed r288825 (246595@main): <https://commits.webkit.org/246595@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450411 [details].
Per Arne Vollan
Comment 6 2022-01-31 15:59:28 PST
Reopening to attach new patch.
Per Arne Vollan
Comment 7 2022-01-31 15:59:29 PST
Created attachment 450472 [details] Patch
Tim Horton
Comment 8 2022-02-01 10:06:44 PST
Comment on attachment 450472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450472&action=review > Source/WebCore/loader/cache/CachedImage.cpp:530 > if (!isPostScriptResource()) I expect there’s a slight bit more simplification we can do here
Per Arne Vollan
Comment 9 2022-02-01 11:05:49 PST
Created attachment 450550 [details] Patch
Per Arne Vollan
Comment 10 2022-02-01 11:06:40 PST
(In reply to Tim Horton from comment #8) > Comment on attachment 450472 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450472&action=review > > > Source/WebCore/loader/cache/CachedImage.cpp:530 > > if (!isPostScriptResource()) > > I expect there’s a slight bit more simplification we can do here Ah, good catch! I updated the patch. Thanks for reviewing!
EWS
Comment 11 2022-02-01 16:09:32 PST
Committed r288922 (246657@main): <https://commits.webkit.org/246657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450550 [details].
David Kilzer (:ddkilzer)
Comment 12 2022-02-07 13:42:40 PST
(In reply to EWS from comment #11) > Committed r288922 (246657@main): <https://commits.webkit.org/246657@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 450550 [details]. Per Arne just removed my very first patch for WebKit for Bug 3527 that landed in r12679! Bug 3527: Allow Safari to open postscript files in browser windows as well <https://bugs.webkit.org/show_bug.cgi?id=3527> <https://commits.webkit.org/r12679>
Note You need to log in before you can comment on or make changes to this bug.