Bug 235892

Summary: [WP] Remove PostScript conversion code
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ddkilzer, ews-watchlist, japhet, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 3527    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
thorton: review+
Patch none

Description Per Arne Vollan 2022-01-31 08:05:02 PST 
The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
Comment 1 Per Arne Vollan 2022-01-31 08:05:28 PST 
<rdar://88172449>
Comment 2 Per Arne Vollan 2022-01-31 08:07:16 PST 
Created attachment 450411 [details]
Patch
Comment 3 Brent Fulgham 2022-01-31 09:53:55 PST 
Comment on attachment 450411 [details]
Patch

r=me
Comment 4 Per Arne Vollan 2022-01-31 11:02:57 PST 
Comment on attachment 450411 [details]
Patch

Thanks for reviewing!
Comment 5 EWS 2022-01-31 11:37:41 PST 
Committed r288825 (246595@main): <https://commits.webkit.org/246595@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450411 [details].
Comment 6 Per Arne Vollan 2022-01-31 15:59:28 PST 
Reopening to attach new patch.
Comment 7 Per Arne Vollan 2022-01-31 15:59:29 PST 
Created attachment 450472 [details]
Patch
Comment 8 Tim Horton 2022-02-01 10:06:44 PST 
Comment on attachment 450472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450472&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:530
>      if (!isPostScriptResource())

I expect there’s a slight bit more simplification we can do here
Comment 9 Per Arne Vollan 2022-02-01 11:05:49 PST 
Created attachment 450550 [details]
Patch
Comment 10 Per Arne Vollan 2022-02-01 11:06:40 PST 
(In reply to Tim Horton from comment #8)
> Comment on attachment 450472 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450472&action=review
> 
> > Source/WebCore/loader/cache/CachedImage.cpp:530
> >      if (!isPostScriptResource())
> 
> I expect there’s a slight bit more simplification we can do here

Ah, good catch! I updated the patch.

Thanks for reviewing!
Comment 11 EWS 2022-02-01 16:09:32 PST 
Committed r288922 (246657@main): <https://commits.webkit.org/246657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450550 [details].
Comment 12 David Kilzer (:ddkilzer) 2022-02-07 13:42:40 PST 
(In reply to EWS from comment #11)
> Committed r288922 (246657@main): <https://commits.webkit.org/246657@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 450550 [details].

Per Arne just removed my very first patch for WebKit for Bug 3527 that landed in r12679!

Bug 3527: Allow Safari to open postscript files in browser windows as well
<https://bugs.webkit.org/show_bug.cgi?id=3527>
<https://commits.webkit.org/r12679>