Summary: | [GStreamer] Support for vpx in webrtc encoder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, philipj, sergio, tommyw, vjaquez, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philippe Normand
2022-01-30 07:52:35 PST
Created attachment 450360 [details]
Patch
Created attachment 450362 [details]
Patch
heh... another patch that I cooked long ago and it bitrotten in my branch. Comment on attachment 450362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450362&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:38 > +static GstStaticPadTemplate srcTemplate = GST_STATIC_PAD_TEMPLATE("src", GST_PAD_SRC, GST_PAD_ALWAYS, GST_STATIC_CAPS("video/x-h264;video/x-vp8;video/x-vp9")); What have worried my about this static (something that had hit me in gstreamer-vaapi) is that the element is offering all these codecs, but we don't effectively assure we have them before offering them via caps template. Thanks for raising this issue :) I'll try to address it in a follow-up patch! Committed r288883 (246635@main): <https://commits.webkit.org/246635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450362 [details]. |