Bug 235870

Summary: [GStreamer] Support for vpx in webrtc encoder
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, philipj, sergio, tommyw, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Philippe Normand
Reported 2022-01-30 07:52:35 PST
.
Attachments
Patch (5.72 KB, patch)
2022-01-30 07:57 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (7.03 KB, patch)
2022-01-30 08:30 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-01-30 07:57:55 PST
Created attachment 450360 [details] Patch
Philippe Normand
Comment 2 2022-01-30 08:30:20 PST
Created attachment 450362 [details] Patch
Víctor M. Jáquez L.
Comment 3 2022-02-01 01:53:12 PST
heh... another patch that I cooked long ago and it bitrotten in my branch.
Víctor M. Jáquez L.
Comment 4 2022-02-01 01:56:49 PST
Comment on attachment 450362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450362&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:38 > +static GstStaticPadTemplate srcTemplate = GST_STATIC_PAD_TEMPLATE("src", GST_PAD_SRC, GST_PAD_ALWAYS, GST_STATIC_CAPS("video/x-h264;video/x-vp8;video/x-vp9")); What have worried my about this static (something that had hit me in gstreamer-vaapi) is that the element is offering all these codecs, but we don't effectively assure we have them before offering them via caps template.
Philippe Normand
Comment 5 2022-02-01 09:13:04 PST
Thanks for raising this issue :) I'll try to address it in a follow-up patch!
EWS
Comment 6 2022-02-01 09:18:21 PST
Committed r288883 (246635@main): <https://commits.webkit.org/246635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450362 [details].
Radar WebKit Bug Importer
Comment 7 2022-02-01 09:19:17 PST
<rdar://problem/88331669>
Note You need to log in before you can comment on or make changes to this bug.