Bug 235870 - [GStreamer] Support for vpx in webrtc encoder
Summary: [GStreamer] Support for vpx in webrtc encoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-30 07:52 PST by Philippe Normand
Modified: 2022-02-01 09:19 PST (History)
14 users (show)

See Also:

Attachments
Patch (5.72 KB, patch)
2022-01-30 07:57 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (7.03 KB, patch)
2022-01-30 08:30 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-01-30 07:52:35 PST 
.
Comment 1 Philippe Normand 2022-01-30 07:57:55 PST 
Created attachment 450360 [details]
Patch
Comment 2 Philippe Normand 2022-01-30 08:30:20 PST 
Created attachment 450362 [details]
Patch
Comment 3 Víctor M. Jáquez L. 2022-02-01 01:53:12 PST 
heh... another patch that I cooked long ago and it bitrotten in my branch.
Comment 4 Víctor M. Jáquez L. 2022-02-01 01:56:49 PST 
Comment on attachment 450362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450362&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:38
> +static GstStaticPadTemplate srcTemplate = GST_STATIC_PAD_TEMPLATE("src", GST_PAD_SRC, GST_PAD_ALWAYS, GST_STATIC_CAPS("video/x-h264;video/x-vp8;video/x-vp9"));

What have worried my about this static (something that had hit me in gstreamer-vaapi)  is that the element is offering all these codecs, but we don't effectively assure we have them before offering them via caps template.
Comment 5 Philippe Normand 2022-02-01 09:13:04 PST 
Thanks for raising this issue :) I'll try to address it in a follow-up patch!
Comment 6 EWS 2022-02-01 09:18:21 PST 
Committed r288883 (246635@main): <https://commits.webkit.org/246635@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450362 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-01 09:19:17 PST 
<rdar://problem/88331669>