Bug 235844

Summary: Collapsed ranges return zero rects in DocumentContext
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-01-28 16:57:36 PST
Collapsed ranges return zero rects in DocumentContext
Attachments
Patch (5.42 KB, patch)
2022-01-28 17:03 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.64 KB, patch)
2022-01-31 14:14 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-01-28 17:03:01 PST
Created attachment 450291 [details] Patch
Tim Horton
Comment 2 2022-01-31 11:20:47 PST
Comment on attachment 450291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450291&action=review > Source/WebKit/ChangeLog:12 > + This results in an understandable zero rect for the absolute bounding rects for that character, > + which is not really representative of what the bounding rect is. For these situations, we should Some reference back to the change you made that broke this would be good. ("Before revision X, we did A; afterwards, we did B, but that's a problem because C" instead of this form that only captures C). You and I know the context right now, but it's going to be quickly lost if not recorded here. > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4576 > + absoluteBoundingBox = VisiblePosition(makeDeprecatedLegacyPosition(iterator.range().start)).absoluteCaretBounds(); is it really right to be adding new `makeDeprecatedLegacyPosition`?
Megan Gardner
Comment 3 2022-01-31 14:14:46 PST
Created attachment 450461 [details] Patch for landing
EWS
Comment 4 2022-01-31 15:12:53 PST
Committed r288849 (246610@main): <https://commits.webkit.org/246610@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450461 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-31 15:13:14 PST
<rdar://problem/88297028>
Note You need to log in before you can comment on or make changes to this bug.