Bug 235838 – [macOS] Expose screen and window capture state to WKWebView

• Component: WebRTC
• Status: RESOLVED FIXED

[Eric Carlson]

Expose screen and window capture state to WKWebView

[Radar WebKit Bug Importer]

<rdar://problem/88207924>

[Eric Carlson]

Created attachment 450287 [details]
Patch

[Eric Carlson]

Created attachment 450426 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Eric Carlson]

Created attachment 450439 [details]
Patch

[youenn fablet]

Comment on attachment 450439 [details]
Patch

Probably worth adding a test validating we delay with a timer the start capture/stop capture.
While this is mostly useful for camera, it is good to validate this will work for display as well.

Another question worth exploring. We might add in the future getViewPortMedia which is specific to capturing the self tab.
We probably want a different delegate, but it may be ok to keep the same display states/mutators APIs.
Wdyt?

View in context: https://bugs.webkit.org/attachment.cgi?id=450439&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4873
> +    UNUSED_PARAM(isFromDisplayCapture);

FIXME: Remove isFromDisplayCapture?

[Eric Carlson]

(In reply to youenn fablet from comment #6)
> Comment on attachment 450439 [details]
> Patch
> 
> Probably worth adding a test validating we delay with a timer the start
> capture/stop capture.
> While this is mostly useful for camera, it is good to validate this will
> work for display as well.
> 
> Another question worth exploring. We might add in the future
> getViewPortMedia which is specific to capturing the self tab.
> We probably want a different delegate, but it may be ok to keep the same
> display states/mutators APIs.
> Wdyt?
> 

Seems reasonable.

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450439&action=review
> 
> > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4873
> > +    UNUSED_PARAM(isFromDisplayCapture);
> 
> FIXME: Remove isFromDisplayCapture?

Good idea, I'll do that.

[Eric Carlson]

Created attachment 450466 [details]
Patch for landing

[Eric Carlson]

Created attachment 450473 [details]
Patch

[Eric Carlson]

Created attachment 450536 [details]
Patch for landing

[EWS]

Committed r288894 (246639@main): <https://commits.webkit.org/246639@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450536 [details].