Bug 235829

Summary: [ews] Implement Login with GitHub on EWS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, psaavedra, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218823
https://bugs.webkit.org/show_bug.cgi?id=252778

Description Aakash Jain 2022-01-28 10:16:17 PST 
Currently EWS doesn't allow login to different users. There is only one account for admins. There are few features which could be benefit for authentication. Since we are anyways going to start using GitHub, we should implement 'Login with GitHub' on EWS. buildbot have some support for Github authentication. https://buildbot.buildbot.net also has 'Login with GitHub' button (on top-right).

Reference: https://docs.buildbot.net/latest/developer/auth.html?highlight=authentication#third-party-authentication
Comment 1 Radar WebKit Bug Importer 2022-01-28 10:16:39 PST 
<rdar://problem/88192177>
Comment 2 Aakash Jain 2023-01-25 16:00:52 PST 
Reference for authorization in buildbot: https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules
Comment 3 Aakash Jain 2023-01-26 14:12:24 PST 
Note that this would allow most of our users to click the 'Retry' button on buildbot builds enabling them to retry failed (or any) build.
Comment 4 Aakash Jain 2023-02-17 03:51:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10266
Comment 5 Aakash Jain 2023-02-17 04:06:34 PST 
*** Bug 244055 has been marked as a duplicate of this bug. ***
Comment 6 EWS 2023-02-20 04:18:53 PST 
Committed 260531@main (a2a8bd0fd59f): <https://commits.webkit.org/260531@main>

Reviewed commits have been landed. Closing PR #10266 and removing active labels.