Bug 235829
| Summary: | [ews] Implement Login with GitHub on EWS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, psaavedra, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=218823 https://bugs.webkit.org/show_bug.cgi?id=252778 |
||
Aakash Jain
Currently EWS doesn't allow login to different users. There is only one account for admins. There are few features which could be benefit for authentication. Since we are anyways going to start using GitHub, we should implement 'Login with GitHub' on EWS. buildbot have some support for Github authentication. https://buildbot.buildbot.net also has 'Login with GitHub' button (on top-right).
Reference: https://docs.buildbot.net/latest/developer/auth.html?highlight=authentication#third-party-authentication
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88192177>
Aakash Jain
Reference for authorization in buildbot: https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules
Aakash Jain
Note that this would allow most of our users to click the 'Retry' button on buildbot builds enabling them to retry failed (or any) build.
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/10266
Aakash Jain
*** Bug 244055 has been marked as a duplicate of this bug. ***
EWS
Committed 260531@main (a2a8bd0fd59f): <https://commits.webkit.org/260531@main>
Reviewed commits have been landed. Closing PR #10266 and removing active labels.
Aakash Jain
Announcement: https://lists.webkit.org/pipermail/webkit-dev/2023-February/032480.html