| Summary: | Ensure session is added in network process when it creates connection to web process | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-01-27 21:26:17 PST
Created attachment 450204 [details]
Patch
Comment on attachment 450204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450204&action=review > Source/WebKit/ChangeLog:10 > + session is added in NetworkProcess::AddWebsiteDataStore, which is sent from UI process before May be easier to just pass DispatchMessageEvenWhenWaitingForSyncReply when sending the NetworkProcess::AddWebsiteDataStore IPC then no? Created attachment 450243 [details]
Patch
Comment on attachment 450243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450243&action=review r=me > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1351 > + send(Messages::NetworkProcess::AddWebsiteDataStore { store.parameters() }, 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply); Would be nice to add a comment in the code to explain why DispatchMessageEvenWhenWaitingForSyncReply is needed. Created attachment 450247 [details]
Patch
Committed r288754 (246545@main): <https://commits.webkit.org/246545@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450247 [details]. |