Bug 235754

Summary: Ensure session is added in network process when it creates connection to web process
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sihui Liu
Reported 2022-01-27 21:26:17 PST
...
Attachments
Patch (7.79 KB, patch)
2022-01-27 21:39 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2022-01-28 09:46 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (2.70 KB, patch)
2022-01-28 09:59 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-01-27 21:39:09 PST
Created attachment 450204 [details] Patch
Chris Dumez
Comment 2 2022-01-28 09:35:48 PST
Comment on attachment 450204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450204&action=review > Source/WebKit/ChangeLog:10 > + session is added in NetworkProcess::AddWebsiteDataStore, which is sent from UI process before May be easier to just pass DispatchMessageEvenWhenWaitingForSyncReply when sending the NetworkProcess::AddWebsiteDataStore IPC then no?
Sihui Liu
Comment 3 2022-01-28 09:46:36 PST
Created attachment 450243 [details] Patch
Chris Dumez
Comment 4 2022-01-28 09:48:29 PST
Comment on attachment 450243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450243&action=review r=me > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1351 > + send(Messages::NetworkProcess::AddWebsiteDataStore { store.parameters() }, 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply); Would be nice to add a comment in the code to explain why DispatchMessageEvenWhenWaitingForSyncReply is needed.
Sihui Liu
Comment 5 2022-01-28 09:59:27 PST
Created attachment 450247 [details] Patch
EWS
Comment 6 2022-01-28 11:53:30 PST
Committed r288754 (246545@main): <https://commits.webkit.org/246545@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450247 [details].
Radar WebKit Bug Importer
Comment 7 2022-01-28 11:54:15 PST
<rdar://problem/88197282>
Note You need to log in before you can comment on or make changes to this bug.