Bug 235754 - Ensure session is added in network process when it creates connection to web process
Summary: Ensure session is added in network process when it creates connection to web ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-27 21:26 PST by Sihui Liu
Modified: 2022-01-28 11:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.79 KB, patch)
2022-01-27 21:39 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2022-01-28 09:46 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (2.70 KB, patch)
2022-01-28 09:59 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-01-27 21:26:17 PST 
...
Comment 1 Sihui Liu 2022-01-27 21:39:09 PST 
Created attachment 450204 [details]
Patch
Comment 2 Chris Dumez 2022-01-28 09:35:48 PST 
Comment on attachment 450204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450204&action=review

> Source/WebKit/ChangeLog:10
> +        session is added in NetworkProcess::AddWebsiteDataStore, which is sent from UI process before 

May be easier to just pass DispatchMessageEvenWhenWaitingForSyncReply when sending the NetworkProcess::AddWebsiteDataStore IPC then no?
Comment 3 Sihui Liu 2022-01-28 09:46:36 PST 
Created attachment 450243 [details]
Patch
Comment 4 Chris Dumez 2022-01-28 09:48:29 PST 
Comment on attachment 450243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450243&action=review

r=me

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:1351
> +        send(Messages::NetworkProcess::AddWebsiteDataStore { store.parameters() }, 0, IPC::SendOption::DispatchMessageEvenWhenWaitingForSyncReply);

Would be nice to add a comment in the code to explain why DispatchMessageEvenWhenWaitingForSyncReply is needed.
Comment 5 Sihui Liu 2022-01-28 09:59:27 PST 
Created attachment 450247 [details]
Patch
Comment 6 EWS 2022-01-28 11:53:30 PST 
Committed r288754 (246545@main): <https://commits.webkit.org/246545@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450247 [details].
Comment 7 Radar WebKit Bug Importer 2022-01-28 11:54:15 PST 
<rdar://problem/88197282>