Bug 235745

Summary:

Support additional WPEToolingBackend types

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Platform

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zan, zdobersek

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
Patch	none
Patch	none

Don Olmstead

Reported 2022-01-27 17:04:43 PST

Currently its all FDO.

Attachments
WIP Patch (19.58 KB, patch) 2022-01-27 17:18 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (20.19 KB, patch) 2022-01-28 10:15 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (20.35 KB, patch) 2022-01-28 10:22 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (20.59 KB, patch) 2022-01-28 10:34 PST, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (20.48 KB, patch) 2022-01-28 10:53 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (22.78 KB, patch) 2022-01-28 11:02 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (22.72 KB, patch) 2022-01-28 11:39 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2022-01-27 17:18:52 PST Comment hidden (obsolete)

Created attachment 450195 [details] WIP Patch

Don Olmstead

Comment 2 2022-01-28 10:15:25 PST Comment hidden (obsolete)

Created attachment 450249 [details] WIP Patch

Don Olmstead

Comment 3 2022-01-28 10:22:54 PST Comment hidden (obsolete)

Created attachment 450250 [details] WIP Patch

Don Olmstead

Comment 4 2022-01-28 10:34:52 PST Comment hidden (obsolete)

Created attachment 450252 [details] WIP Patch

Don Olmstead

Comment 5 2022-01-28 10:53:04 PST Comment hidden (obsolete)

Created attachment 450258 [details] WIP Patch

Don Olmstead

Comment 6 2022-01-28 11:02:19 PST Comment hidden (obsolete)

Created attachment 450259 [details] Patch

Don Olmstead

Comment 7 2022-01-28 11:39:45 PST

Created attachment 450262 [details] Patch

Don Olmstead

Comment 8 2022-01-30 14:17:47 PST

This patch only touches WPE code so the Mac failures are bogus.

Adrian Perez

Comment 9 2022-01-31 04:33:16 PST

Comment on attachment 450262 [details] Patch The patch looks reasonable to me, as it is mostly moving things around. I will wait a bit before setting it as r+, to see if Žan can take a quick look as well :)

Zan Dobersek

Comment 10 2022-01-31 05:22:50 PST

Looks fine.

EWS

Comment 11 2022-01-31 07:15:38 PST

Committed r288814 (246590@main): <https://commits.webkit.org/246590@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450262 [details].

Radar WebKit Bug Importer

Comment 12 2022-01-31 07:16:26 PST

<rdar://problem/88268667>

Note You need to log in before you can comment on or make changes to this bug.