Bug 235745

Summary: Support additional WPEToolingBackend types
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: PlatformAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zan, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
ews-feeder: commit-queue-
WIP Patch
none
Patch
none
Patch none

Description Don Olmstead 2022-01-27 17:04:43 PST 
Currently its all FDO.
Comment 1 Don Olmstead 2022-01-27 17:18:52 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2022-01-28 10:15:25 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2022-01-28 10:22:54 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2022-01-28 10:34:52 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2022-01-28 10:53:04 PST Comment hidden (obsolete)
Comment 6 Don Olmstead 2022-01-28 11:02:19 PST Comment hidden (obsolete)
Comment 7 Don Olmstead 2022-01-28 11:39:45 PST 
Created attachment 450262 [details]
Patch
Comment 8 Don Olmstead 2022-01-30 14:17:47 PST 
This patch only touches WPE code so the Mac failures are bogus.
Comment 9 Adrian Perez 2022-01-31 04:33:16 PST 
Comment on attachment 450262 [details]
Patch

The patch looks reasonable to me, as it is mostly moving things around.
I will wait a bit before setting it as r+, to see if Žan can take a quick
look as well :)
Comment 10 Zan Dobersek 2022-01-31 05:22:50 PST 
Looks fine.
Comment 11 EWS 2022-01-31 07:15:38 PST 
Committed r288814 (246590@main): <https://commits.webkit.org/246590@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450262 [details].
Comment 12 Radar WebKit Bug Importer 2022-01-31 07:16:26 PST 
<rdar://problem/88268667>