Bug 23574

Summary: add #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor
Product: WebKit Reporter: Feng Qian <feng>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: caryclark
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch v1
eric: review+
patch with my name eric: review+

Feng Qian
Reported 2009-01-27 12:50:21 PST
EventHanlder::setPanScrollCursor is a private method of EventHandler class, and it is only used by autoscrollTimerFired when ENABLE(PAN_SCROLLING) is true. Putting #if ENABLE(PAN_SCROLLING) around Event::setPanScrollCursor can save some bytes for platforms that do not support pan scrolling.
Attachments
patch v1 (1.68 KB, patch)
2009-01-27 12:54 PST, Feng Qian 		eric: review+
DetailsFormatted DiffDiff
patch with my name (1.68 KB, patch)
2009-02-06 15:58 PST, Feng Qian 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Feng Qian
Comment 1 2009-01-27 12:54:37 PST
Created attachment 27082 [details] patch v1
Holger Freyther
Comment 2 2009-01-31 12:10:20 PST
Can't you compile the libWebCore to an archive (.a) file and let the linker sort that out?
Feng Qian
Comment 3 2009-02-02 09:31:30 PST
On Android platform, libwebcore is compiled as a shared library (used by browser and other apps). In this case, I think a smart linker should be able to strip setPanScrollCursor off since the function is private and not used, but the linker seems not as smart as we want :( (In reply to comment #2) > Can't you compile the libWebCore to an archive (.a) file and let the linker > sort that out? >
Eric Seidel (no email)
Comment 4 2009-02-06 14:23:07 PST
Comment on attachment 27082 [details] patch v1 The patch looks fine. The ChangeLog needs your full name. You should investigate setting the CHANGE_LOG_NAME environment variable. see prepare-ChangeLog for more info.
Feng Qian
Comment 5 2009-02-06 15:58:05 PST
Created attachment 27430 [details] patch with my name Thanks, Eric Updated the patch with fixed name in the changeLog.
Eric Seidel (no email)
Comment 6 2009-02-06 15:59:35 PST
Comment on attachment 27430 [details] patch with my name Still looks good. :)
Brent Fulgham
Comment 7 2009-02-07 18:48:44 PST
Committed in http://trac.webkit.org/changeset/40767
Note You need to log in before you can comment on or make changes to this bug.