Bug 235734

Summary: com.apple.WebKit.WebAuthn.xpc fails to build with system content path
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, fpizlo, keith_miller, mark.lam, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+, ews-feeder: commit-queue-

Description Michael Saboff 2022-01-27 14:25:10 PST
The following build commands failed:
        PhaseScriptExecution Create Symlink to Alt Root Path in target 'WebAuthn' from project 'WebKit'
error: expected a symlink at ..../Library/Frameworks/WebKit.framework/XPCServices/com.apple.WebKit.WebAuthn.xpc

There are also some errors when trying to build for Mac Catalyst where we don't take into account the Catalyst path prefix.
Comment 1 Michael Saboff 2022-01-27 14:26:26 PST
<rdar://88100509>
Comment 2 Michael Saboff 2022-01-27 14:47:54 PST
Created attachment 450183 [details]
Patch
Comment 3 Keith Miller 2022-01-27 14:56:27 PST
Comment on attachment 450183 [details]
Patch

Seems reasonable, r=me
Comment 4 Michael Saboff 2022-01-27 16:24:25 PST
Committed r288710 (?): <https://commits.webkit.org/r288710>