Bug 23573

Summary: Make PlatformWidget an intptr_t on Chromium
Product: WebKit Reporter: Adam Langley <agl>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
sam: review-
proposed patch sam: review+

Adam Langley
Reported 2009-01-27 12:29:49 PST
2009-01-27 Adam Langley <agl@google.com> Reviewed by NOBODY (OOPS!). Make PlatformWidget on chromium an intptr_t * platform/chromium/PlatformWidget.h:
Attachments
Proposed patch (1.21 KB, patch)
2009-01-27 12:30 PST, Adam Langley 		sam: review-
DetailsFormatted DiffDiff
proposed patch (1.21 KB, patch)
2009-01-27 15:30 PST, Adam Langley 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-01-27 12:30:50 PST
Created attachment 27081 [details] Proposed patch
Sam Weinig
Comment 2 2009-01-27 14:38:24 PST
Comment on attachment 27081 [details] Proposed patch +#include <wtf/Assertions.h> // for intptr_t This doesn't make a lot of sense. Please use the correct system header.
Adam Langley
Comment 3 2009-01-27 14:43:29 PST
The correct system header (stdint.h) doesn't exist on Windows. Assertions.h contains this code: #if COMPILER(MSVC) #include <stddef.h> #else #include <inttypes.h> #endif Which I can duplicate if you wish, but it seemed better to keep the #ifdefs down.
Alexey Proskuryakov
Comment 4 2009-01-27 14:51:46 PST
I think that it could go in StdLibExtras.h (which in fact includes Assertions.h now).
Adam Langley
Comment 5 2009-01-27 15:30:54 PST
Created attachment 27089 [details] proposed patch
Adam Langley
Comment 6 2009-01-27 15:31:11 PST
Updated to use StdLibExtras.h
Sam Weinig
Comment 7 2009-01-27 17:20:29 PST
Comment on attachment 27089 [details] proposed patch > @@ -1,3 +1,11 @@ > +2009-01-27 Adam Langley <agl@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Make PlatformWidget on chromium an intptr_t This should include a why, not just a what.
Darin Fisher (:fishd, Google)
Comment 8 2009-01-28 10:52:32 PST
http://trac.webkit.org/changeset/40314
Note You need to log in before you can comment on or make changes to this bug.