Bug 235724

Summary: [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
Product: WebKit Reporter: Elliott Williams <emw>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Elliott Williams
Reported 2022-01-27 10:47:47 PST
[XCBuild] Missing task dependencies on generate-unified-source-bundles.rb
Attachments
Patch (5.32 KB, patch)
2022-01-27 11:02 PST, Elliott Williams 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2022-01-27 10:49:33 PST
The targets which generate unified sources all use /usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb, but do not declare it. In workspace builds, WTF may not have been built and this header may not exist yet.
Elliott Williams
Comment 2 2022-01-27 11:02:43 PST
Created attachment 450159 [details] Patch
EWS
Comment 3 2022-01-27 12:51:13 PST
Committed r288696 (246494@main): <https://commits.webkit.org/246494@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450159 [details].
Radar WebKit Bug Importer
Comment 4 2022-01-27 12:52:16 PST
<rdar://problem/88148866>
Note You need to log in before you can comment on or make changes to this bug.