Bug 235698

Summary:

[GTK][a11y] Return null reference for root parent reference if queried before being embedded

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

230253

Attachments:

Description	Flags
Patch	aperez: review+, aperez: commit-queue-

Description Carlos Garcia Campos 2022-01-27 01:44:53 PST

Once embedded parent-changed will be emitted.

Comment 1 Carlos Garcia Campos 2022-01-27 01:48:05 PST

Created attachment 450115 [details]
Patch

Comment 2 Adrian Perez 2022-01-27 05:01:22 PST

Comment on attachment 450115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450115&action=review

> Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:198
> +	return AccessibilityAtspi::singleton().nullReference();

There are tabs used for indentation in this line (this is what the style bot
shouted about), please fix it before landing.

Comment 3 Carlos Garcia Campos 2022-01-27 22:59:01 PST

Committed r288724 (246517@trunk): <https://commits.webkit.org/246517@trunk>