Bug 235697

Summary:

<model> should not be draggable on macOS

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

New Bugs

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dino, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=229246

Bug Depends on:

235725

Bug Blocks:

227621

Attachments:

Description	Flags
Patch	dino: review+
Patch for landing	ews-feeder: commit-queue-

Description Antoine Quint 2022-01-27 01:07:27 PST

<model> should only be draggable on iOS

Comment 1 Antoine Quint 2022-01-27 01:12:53 PST

Created attachment 450114 [details]
Patch

Comment 2 Antoine Quint 2022-01-27 01:13:24 PST

We're turning off <model> dragging for macOS in bug 227621.

Comment 3 Antoine Quint 2022-01-27 01:27:48 PST

Please ignore that last comment, it was a mistake.

Comment 4 Antoine Quint 2022-01-27 03:08:51 PST

Committed r288670 (246476@trunk): <https://commits.webkit.org/246476@trunk>

Comment 5 Radar WebKit Bug Importer 2022-01-27 03:09:17 PST

<rdar://problem/88123683>

Comment 6 Aakash Jain 2022-01-27 11:34:21 PST

(In reply to Antoine Quint from comment #4)
> Committed r288670 (246476@trunk): <https://commits.webkit.org/246476@trunk>
This manual commit broke an iOS api test.
See: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.DragAndDropTests.CanStartDragOnModel

EWS failure: https://ews-build.webkit.org/#/builders/9/builds/63450

This is now slowing down the api-ios ews queue.

Comment 7 WebKit Commit Bot 2022-01-27 12:05:35 PST

Re-opened since this is blocked by bug 235725

Comment 8 Antoine Quint 2022-01-27 12:59:16 PST

Created attachment 450167 [details]
Patch for landing

Comment 9 Antoine Quint 2022-01-27 22:54:11 PST

Committed r288723 (246516@trunk): <https://commits.webkit.org/246516@trunk>