Bug 235680
| Summary: | const/non-const and inclusive/non-inclusive shared code improvements for RenderDescendantIterator adapters | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Gabriel Nava Marino <gnavamarino> |
| Component: | Layout and Rendering | Assignee: | Gabriel Nava Marino <gnavamarino> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Gabriel Nava Marino
As pointed out in https://bugs.webkit.org/show_bug.cgi?id=234018#c28:
To avoid code duplication, we should find a way to share code between the non-inclusive and inclusive RenderDescendantIteratorAdapters, since the non-inclusive case is just like inclusive case, but just skipping the thing itself.
We should also find a way to support a const reference for descendantsOfType, similarly in a way that avoids duplicating all the code twice, such as by using some const_cast in the implementation.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88407384>