Bug 235614

Summary: globalThis.queueMicrotask() should report thrown exceptions
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: DOMAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Minor CC: annulen, cdumez, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, hi, joepeck, kangil.han, keith_miller, mark.lam, mkwst, msaboff, pangle, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235682
Attachments:
Description Flags
Patch
none
Patch none

Description Alexey Shvayka 2022-01-25 15:27:31 PST 
globalThis.queueMicrotask() should report thrown exceptions
Comment 1 Alexey Shvayka 2022-01-25 15:32:32 PST 
Created attachment 449973 [details]
Patch
Comment 2 Geoffrey Garen 2022-01-25 15:44:32 PST 
Comment on attachment 449973 [details]
Patch

r=me
Comment 3 Mark Lam 2022-01-25 15:53:03 PST 
Comment on attachment 449973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449973&action=review

> Source/WebCore/bindings/js/JSDOMMicrotask.cpp:39
> +class JSDOMMicrotask final : public Microtask {

WTF_MAKE_FAST_ALLOCATED?
Comment 4 Mark Lam 2022-01-25 15:54:36 PST 
Comment on attachment 449973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449973&action=review

>> Source/WebCore/bindings/js/JSDOMMicrotask.cpp:39
>> +class JSDOMMicrotask final : public Microtask {
> 
> WTF_MAKE_FAST_ALLOCATED?

Nevermind.  Since this ultimately inherits from RefCounted, it is already WTF_MAKE_FAST_ALLOCATED.
Comment 5 Alexey Shvayka 2022-01-25 19:25:17 PST 
Created attachment 449992 [details]
Patch

Skip SW test on mac-wk1, reset expectations for inspector test, and remove now unused createJSMicrotask() overload.
Comment 6 Alexey Shvayka 2022-01-26 12:10:23 PST 
Committed r288640 (246451@trunk): <https://commits.webkit.org/246451@trunk>
Comment 7 Radar WebKit Bug Importer 2022-01-26 12:11:20 PST 
<rdar://problem/88088960>
Comment 8 Alexey Shvayka 2022-01-26 12:12:12 PST 
Thank you both!