Bug 235599

Summary: [macOS][WP] Allow mach extension to service
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Per Arne Vollan
Reported 2022-01-25 10:42:37 PST
Allow mach extension to a service in the WebContent process on macOS.
Attachments
Patch (1.40 KB, patch)
2022-01-25 10:53 PST, Per Arne Vollan 		darin: review+
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2022-01-25 16:04 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2022-01-25 10:42:57 PST
<rdar://87850345>
Per Arne Vollan
Comment 2 2022-01-25 10:53:20 PST
Created attachment 449942 [details] Patch
Darin Adler
Comment 3 2022-01-25 15:08:12 PST
Comment on attachment 449942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449942&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1111 > +;; rdar://87850345 Generally in WebKit we try to put comments that would work for people even outside Apple, so a Radar link is not the right pattern. It’s possible, though, that the sandbox profile is an exception to this.
Per Arne Vollan
Comment 4 2022-01-25 16:04:43 PST
Created attachment 449978 [details] Patch
Per Arne Vollan
Comment 5 2022-01-25 16:05:49 PST
(In reply to Darin Adler from comment #3) > Comment on attachment 449942 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449942&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1111 > > +;; rdar://87850345 > > Generally in WebKit we try to put comments that would work for people even > outside Apple, so a Radar link is not the right pattern. It’s possible, > though, that the sandbox profile is an exception to this. That is a good point. I have added a short comment in addition to the Radar link. Thanks for reviewing!
EWS
Comment 6 2022-01-25 17:02:35 PST
Committed r288591 (246413@main): <https://commits.webkit.org/246413@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449978 [details].
Note You need to log in before you can comment on or make changes to this bug.