Bug 23553

Summary: Upstream changes from jcampan to fix chromium bugs 6692 and 6694
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch eric: review+

Darin Fisher (:fishd, Google)
Reported 2009-01-26 14:51:57 PST
Upstream changes from jcampan to fix chromium bugs 6692 and 6694 Here's the code review details: http://codereview.chromium.org/18466 And the repository revision: http://src.chromium.org/viewvc/chrome?view=rev&revision=8482
Attachments
v1 patch (8.56 KB, patch)
2009-01-26 14:52 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-01-26 14:52:51 PST
Created attachment 27049 [details] v1 patch
Eric Seidel (no email)
Comment 2 2009-01-26 15:02:40 PST
Comment on attachment 27049 [details] v1 patch This looks fine. I would have named things differently, but making you make renaming changes just adds needless trouble for the next merge. We need to get off this silly merge branch.
Darin Fisher (:fishd, Google)
Comment 3 2009-01-26 15:07:05 PST
http://trac.webkit.org/changeset/40269 I cleaned up some of the "bool value" usage in the header file and fixed a few mistypes in the comments.
Note You need to log in before you can comment on or make changes to this bug.