Bug 23553

Summary:

Upstream changes from jcampan to fix chromium bugs 6692 and 6694

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Platform

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
v1 patch	eric: review+

Description Darin Fisher (:fishd, Google) 2009-01-26 14:51:57 PST

Upstream changes from jcampan to fix chromium bugs 6692 and 6694

Here's the code review details:
http://codereview.chromium.org/18466

And the repository revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8482

Comment 1 Darin Fisher (:fishd, Google) 2009-01-26 14:52:51 PST

Created attachment 27049 [details]
v1 patch

Comment 2 Eric Seidel (no email) 2009-01-26 15:02:40 PST

Comment on attachment 27049 [details]
v1 patch

This looks fine.  I would have named things differently, but making you make renaming changes just adds needless trouble for the next merge.  We need to get off this silly merge branch.

Comment 3 Darin Fisher (:fishd, Google) 2009-01-26 15:07:05 PST

http://trac.webkit.org/changeset/40269

I cleaned up some of the "bool value" usage in the header file and fixed a few mistypes in the comments.