Bug 235522

Summary: [Forms] Fix input type email visible value update
Product: WebKit Reporter: zsun
Component: FormsAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, mifenton, ntim, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zsun 2022-01-24 08:48:49 PST 
Affect test

imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value.html
Comment 1 zsun 2022-01-24 08:53:07 PST 
Created attachment 449823 [details]
Patch
Comment 2 zsun 2022-01-24 08:53:56 PST 
Not ready for review yet.
Comment 3 Radar WebKit Bug Importer 2022-01-31 09:38:43 PST 
<rdar://problem/88276285>
Comment 4 zsun 2022-05-17 02:36:24 PDT 
Created attachment 459493 [details]
Patch
Comment 5 Chris Dumez 2022-05-17 07:57:35 PDT 
Comment on attachment 459493 [details]
Patch

r=me
Comment 6 Tim Nguyen (:ntim) 2022-05-18 01:16:43 PDT 
Comment on attachment 459493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459493&action=review

> Source/WebCore/html/TextFieldInputType.cpp:146
> +    bool needTextUpdate = valueChanged || (eventBehavior == TextFieldEventBehavior::DispatchNoEvent && sanitizedValue != element()->innerTextValue());
> +    if (needTextUpdate)

grammar nit: needsTextUpdate
Comment 7 zsun 2022-05-19 01:56:38 PDT 
Created attachment 459572 [details]
Patch
Comment 8 EWS 2022-05-19 04:42:49 PDT 
Committed r294476 (250735@main): <https://commits.webkit.org/250735@main>

Reviewed commits have been landed. Closing PR #774 and removing active labels.