Bug 235465
| Summary: | MediaPlayerPrivateRemote::play() and MediaPlayerPrivateRemote::pause() modify m_cachedState.paused | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Peng Liu
The following change is desired, but it will lead to a test timeout. (media/track/track-cues-pause-on-exit.html)
diff --git a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
index 9a6429437842f43db6da1c25011ed4a544cbf361..cd1c9eaa70f47ecb7cf09b69c8c0bbdd00f29f43 100644
--- a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
+++ b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
@@ -227,13 +227,11 @@ void MediaPlayerPrivateRemote::prepareToPlay()
void MediaPlayerPrivateRemote::play()
{
- m_cachedState.paused = false;
connection().send(Messages::RemoteMediaPlayerProxy::Play(), m_id);
}
void MediaPlayerPrivateRemote::pause()
{
- m_cachedState.paused = true;
auto now = MonotonicTime::now();
m_cachedMediaTime += MediaTime::createWithDouble(m_rate * (now - m_cachedMediaTimeQueryTime).value());
m_cachedMediaTimeQueryTime = now;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88214629>