Bug 235455

Summary: CSSImportRule.layerName not working when building with CMake
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, darin, ews-watchlist, gyuyoung.kim, koivisto, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231340    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Oriol Brufau 2022-01-21 14:29:58 PST 
Bug 231340 added support for CSSImportRule.layerName (https://drafts.csswg.org/css-cascade-5/#extensions-to-cssimportrule-interface)

However, it doesn't exist when running WebKitGTK minibrowser, e.g.
Tools/Scripts/run-minibrowser --gtk 'http://wpt.live/css/css-cascade/layer-rules-cssom.html'
fails some tests.

This also affects wpt.fyi, lowering WebKitGTK's score for interop-2022-cascade:
https://wpt.fyi/results/css/css-cascade/layer-rules-cssom.html?label=master&label=experimental&product=webkitgtk&aligned&q=label%3Ainterop-2022-cascade

I guess it's because WebKitGTK uses CMake, and CSSImportRule+Layer.idl was not included in CMakeLists.txt
Comment 1 Oriol Brufau 2022-01-21 14:39:45 PST 
Created attachment 449696 [details]
Patch
Comment 2 Oriol Brufau 2022-01-21 16:31:17 PST 
Created attachment 449709 [details]
Patch
Comment 3 Oriol Brufau 2022-01-21 17:43:29 PST 
Created attachment 449714 [details]
Patch
Comment 4 Oriol Brufau 2022-01-21 17:46:55 PST 
Didn't notice that css/css-cascade/idlharness.html is also passing now.
Comment 5 EWS 2022-01-22 09:27:42 PST 
Committed r288404 (246295@main): <https://commits.webkit.org/246295@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449714 [details].
Comment 6 Radar WebKit Bug Importer 2022-01-22 09:28:16 PST 
<rdar://problem/87926717>