Bug 23539

Summary: Form control specific methods could be moved away from Node/Element
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: DOMAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, hyatt
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Initial patch hyatt: review+

Description Nikolas Zimmermann 2009-01-25 17:49:19 PST 
Some virtual methods living in Node/Element are related to form control elements only.
isAutofilled / isTextControl / etc... (nine methods in total)

As we now have some abstract base classes for form control elements (FormControlElement/InputElement/etc) we could add pure-virtual methods there, instead of jamming Node/Element.

Proof-on-concept patch following.
Comment 1 Nikolas Zimmermann 2009-01-25 17:53:57 PST 
Created attachment 27032 [details]
Initial patch

As discussed on IRC, would be great if Dave could check this.
Comment 2 Dave Hyatt 2009-01-28 14:07:25 PST 
Comment on attachment 27032 [details]
Initial patch

Looks good.
Comment 3 Nikolas Zimmermann 2009-01-29 13:23:27 PST 
Landed in r40370.
Comment 4 Lucas Forschler 2019-02-06 09:03:23 PST 
Mass moving XML DOM bugs to the "DOM" Component.