Bug 235383

Summary:	[EWS] Use token when processing hook
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=234847 https://bugs.webkit.org/show_bug.cgi?id=235417

Description Jonathan Bedard 2022-01-19 14:31:51 PST

buildbot may make a GET request to GitHub when processing a GitHub hook. We should provide our authentication token when making this request so the build-master doesn't get throttled.

Comment 1 Radar WebKit Bug Importer 2022-01-19 14:32:06 PST

<rdar://problem/87791577>

Comment 2 Aakash Jain 2022-01-19 15:07:26 PST

> buildbot may make a GET request to GitHub when processing a GitHub hook.
Can you please elaborate more on this? Why is a outgoing network request needed to process incoming data?

Comment 3 Jonathan Bedard 2022-01-19 16:45:34 PST

(In reply to Aakash Jain from comment #2)
> > buildbot may make a GET request to GitHub when processing a GitHub hook.
> Can you please elaborate more on this? Why is a outgoing network request
> needed to process incoming data?

Looks like buildbot reaches out to the GitHub API to search commit messages for a skip pattern: https://github.com/buildbot/buildbot/blob/b856c90fb15e156903228f9a461f4ac8051d70cf/master/buildbot/www/hooks/github.py

Comment 4 Jonathan Bedard 2022-01-20 13:24:21 PST

Doing https://bugs.webkit.org/show_bug.cgi?id=235417 instead of this.

Comment 5 Jonathan Bedard 2022-01-21 12:31:34 PST

Landed 246270@main (r288368)