Bug 235379

Summary: Turn EUnicodeBidi into an enum class
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, mifenton, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description zalan 2022-01-19 12:54:15 PST 
ssia
Comment 1 zalan 2022-01-19 13:08:08 PST 
Created attachment 449509 [details]
Patch
Comment 2 zalan 2022-01-19 13:32:39 PST 
Created attachment 449512 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-01-19 13:33:16 PST 
Comment on attachment 449512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review

> Source/WebCore/platform/text/UnicodeBidi.h:31
> +enum class EUnicodeBidi : uint8_t {

Can we drop the E prefix?
Comment 4 zalan 2022-01-19 13:44:01 PST 
(In reply to zalan from comment #2)
> Created attachment 449512 [details]
> Patch
Good point!
Comment 5 Antti Koivisto 2022-01-19 13:45:06 PST 
Comment on attachment 449512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review

>> Source/WebCore/platform/text/UnicodeBidi.h:31
>> +enum class EUnicodeBidi : uint8_t {
> 
> Can we drop the E prefix?

We should.
Comment 6 zalan 2022-01-19 13:58:13 PST 
Created attachment 449516 [details]
Patch
Comment 7 EWS 2022-01-19 17:08:04 PST 
Committed r288254 (246204@main): <https://commits.webkit.org/246204@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449516 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-19 17:09:16 PST 
<rdar://problem/87799957>
Comment 9 Darin Adler 2022-01-19 18:14:45 PST 
Comment on attachment 449516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449516&action=review

> Source/WebCore/platform/text/UnicodeBidi.h:32
>      UBNormal,

Need to rename this to just "Normal" now that it’s in an enum class and will always appear as UnicodeBidi::Normal.
Comment 10 zalan 2022-01-19 19:15:24 PST 
(In reply to Darin Adler from comment #9)
> Comment on attachment 449516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449516&action=review
> 
> > Source/WebCore/platform/text/UnicodeBidi.h:32
> >      UBNormal,
> 
> Need to rename this to just "Normal" now that it’s in an enum class and will
> always appear as UnicodeBidi::Normal.
Oh I missed that. Thanks!
Comment 11 zalan 2022-01-19 19:33:27 PST 
Created attachment 449544 [details]
Patch

address post-landing feedback.
Comment 12 zalan 2022-01-19 19:33:49 PST 
see above
Comment 13 EWS 2022-01-20 05:34:48 PST 
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 14 zalan 2022-01-20 07:11:38 PST 
Created attachment 449572 [details]
Patch
Comment 15 EWS 2022-01-20 07:59:59 PST 
Committed r288291 (246216@main): <https://commits.webkit.org/246216@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449572 [details].