Bug 235379

Summary: Turn EUnicodeBidi into an enum class
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, mifenton, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

alan
Reported 2022-01-19 12:54:15 PST
ssia
Attachments
Patch (12.06 KB, patch)
2022-01-19 13:08 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (12.88 KB, patch)
2022-01-19 13:32 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (24.70 KB, patch)
2022-01-19 13:58 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (8.35 KB, patch)
2022-01-19 19:33 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (8.40 KB, patch)
2022-01-20 07:11 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-01-19 13:08:08 PST
Created attachment 449509 [details] Patch
alan
Comment 2 2022-01-19 13:32:39 PST
Created attachment 449512 [details] Patch
Simon Fraser (smfr)
Comment 3 2022-01-19 13:33:16 PST
Comment on attachment 449512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review > Source/WebCore/platform/text/UnicodeBidi.h:31 > +enum class EUnicodeBidi : uint8_t { Can we drop the E prefix?
alan
Comment 4 2022-01-19 13:44:01 PST
(In reply to zalan from comment #2) > Created attachment 449512 [details] > Patch Good point!
Antti Koivisto
Comment 5 2022-01-19 13:45:06 PST
Comment on attachment 449512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review >> Source/WebCore/platform/text/UnicodeBidi.h:31 >> +enum class EUnicodeBidi : uint8_t { > > Can we drop the E prefix? We should.
alan
Comment 6 2022-01-19 13:58:13 PST
Created attachment 449516 [details] Patch
EWS
Comment 7 2022-01-19 17:08:04 PST
Committed r288254 (246204@main): <https://commits.webkit.org/246204@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449516 [details].
Radar WebKit Bug Importer
Comment 8 2022-01-19 17:09:16 PST
<rdar://problem/87799957>
Darin Adler
Comment 9 2022-01-19 18:14:45 PST
Comment on attachment 449516 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449516&action=review > Source/WebCore/platform/text/UnicodeBidi.h:32 > UBNormal, Need to rename this to just "Normal" now that it’s in an enum class and will always appear as UnicodeBidi::Normal.
alan
Comment 10 2022-01-19 19:15:24 PST
(In reply to Darin Adler from comment #9) > Comment on attachment 449516 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449516&action=review > > > Source/WebCore/platform/text/UnicodeBidi.h:32 > > UBNormal, > > Need to rename this to just "Normal" now that it’s in an enum class and will > always appear as UnicodeBidi::Normal. Oh I missed that. Thanks!
alan
Comment 11 2022-01-19 19:33:27 PST
Created attachment 449544 [details] Patch address post-landing feedback.
alan
Comment 12 2022-01-19 19:33:49 PST
see above
EWS
Comment 13 2022-01-20 05:34:48 PST
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
alan
Comment 14 2022-01-20 07:11:38 PST
Created attachment 449572 [details] Patch
EWS
Comment 15 2022-01-20 07:59:59 PST
Committed r288291 (246216@main): <https://commits.webkit.org/246216@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449572 [details].
Note You need to log in before you can comment on or make changes to this bug.