Bug 235374
| Summary: | ValidatePatch shouldn't fetch the same PR information twice | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Aakash Jain
ValidatePatch shouldn't fetch the same PR information twice. Currently it is fetching same information twice, both _is_pr_closed() and _is_pr_obsolete() methods call get_pr_json() which does network call to github to fetch PR information. Two calls to same url can be seen in https://ews-build.webkit-uat.org/#/builders/1/builds/1694/steps/3/logs/stdio
This code was added recently in https://commits.webkit.org/246047@main (https://github.com/WebKit/WebKit/pull/62).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88090121>
Jonathan Bedard
*** This bug has been marked as a duplicate of bug 235716 ***