| Summary: | Speedometer should be locally runnable on Windows | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, don.olmstead, ews-watchlist, jbedard, rniwa, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2022-01-18 14:36:32 PST
Created attachment 449427 [details]
Patch
Comment on attachment 449427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449427&action=review r=me > PerformanceTests/.gitattributes:8 > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/todomvc-5d3e8eb3d5b3740a33185edcb11eeb57.js -crlf > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/vendor-820919567eb7bd4d9fac358a90a5aac4.js -crlf My only concern is that the hash would be updated and then this issue would crop up again but that's minor. (In reply to Don Olmstead from comment #2) > Comment on attachment 449427 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449427&action=review > > r=me > > > PerformanceTests/.gitattributes:8 > > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/todomvc-5d3e8eb3d5b3740a33185edcb11eeb57.js -crlf > > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/vendor-820919567eb7bd4d9fac358a90a5aac4.js -crlf > > My only concern is that the hash would be updated and then this issue would > crop up again but that's minor. Good call, I think I can use *.js instead. Created attachment 449430 [details]
Patch for landing
Committed r288154 (246149@main): <https://commits.webkit.org/246149@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449430 [details]. |