Bug 235273

Summary: [GTK][STABLE] Missing headers for non-unified 2.34.3 build
Product: WebKit Reporter: Dennis Nezic <dennisn>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: annulen, bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
missing headers patch none

Dennis Nezic
Reported 2022-01-15 13:36:45 PST
These missing #include's caused my non-unified compilation to fail.
Attachments
missing headers patch (2.15 KB, patch)
2022-01-15 13:37 PST, Dennis Nezic 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dennis Nezic
Comment 1 2022-01-15 13:37:24 PST
Created attachment 449268 [details] missing headers patch
Dennis Nezic
Comment 2 2022-01-15 14:37:30 PST
WebCore/css/calc/CSSCalcOperationNode.cpp and ebCore/css/calc/CSSCalcPrimitiveValueNode.cpp weren't able to see the definition of LOG_WITH_STREAM() WebCore/page/EventHandler.cpp wasn't able to recognize SetForScope() WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h wasn't able to recognize WebCore::FloatPoint ... but apparently only #if PLATFORM(GTK) ... so we should probably update the patch. It also wasn't able to find #include <WebCore/CoordinatedGraphicsLayer.h>, so I guess that needed to be wrapped in that additional #if USE(COORDINATED_GRAPHICS) WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h didn't recognize adjustTransientZoom() and commitTransientZoom()
Michael Catanzaro
Comment 3 2022-01-21 13:45:23 PST
Please include a ChangeLog and make sure it passes EWS (patch must apply to trunk). Then you can separately submit a patch for the stable branch (which of course doesn't need to pass EWS).
Dennis Nezic
Comment 4 2022-01-23 13:45:49 PST
*** This bug has been marked as a duplicate of bug 235444 ***
Note You need to log in before you can comment on or make changes to this bug.