Summary: | [GTK][STABLE] Missing headers for non-unified 2.34.3 build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dennis Nezic <dennisn> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | annulen, bugs-noreply, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Dennis Nezic
2022-01-15 13:36:45 PST
Created attachment 449268 [details]
missing headers patch
WebCore/css/calc/CSSCalcOperationNode.cpp and ebCore/css/calc/CSSCalcPrimitiveValueNode.cpp weren't able to see the definition of LOG_WITH_STREAM() WebCore/page/EventHandler.cpp wasn't able to recognize SetForScope() WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h wasn't able to recognize WebCore::FloatPoint ... but apparently only #if PLATFORM(GTK) ... so we should probably update the patch. It also wasn't able to find #include <WebCore/CoordinatedGraphicsLayer.h>, so I guess that needed to be wrapped in that additional #if USE(COORDINATED_GRAPHICS) WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h didn't recognize adjustTransientZoom() and commitTransientZoom() Please include a ChangeLog and make sure it passes EWS (patch must apply to trunk). Then you can separately submit a patch for the stable branch (which of course doesn't need to pass EWS). *** This bug has been marked as a duplicate of bug 235444 *** |