Bug 235258

Summary: First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, bfulgham, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, heycam, jcraig, jdiggs, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, pdr, samuel_white, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
zalan: review+, ews-feeder: commit-queue-
Patch for landing none

Description Darin Adler 2022-01-14 16:57:36 PST 
First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Comment 1 Darin Adler 2022-01-14 17:11:57 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2022-01-14 17:20:01 PST 
Created attachment 449235 [details]
Patch
Comment 3 zalan 2022-01-14 18:46:17 PST 
Comment on attachment 449235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449235&action=review

> Source/WebCore/rendering/RenderReplica.cpp:48
> +    // FIXME: Is the comment above obsolete? Can't find a check of isReplacedOrInlineBlock guarding setHasTransform any more.
> +    setReplacedOrInlineBlock(true);

Curious.
Comment 4 Darin Adler 2022-01-15 14:01:05 PST 
Created attachment 449269 [details]
Patch for landing
Comment 5 Darin Adler 2022-01-15 14:29:35 PST 
Committed r288067 (?): <https://commits.webkit.org/r288067>
Comment 6 Radar WebKit Bug Importer 2022-01-15 14:30:18 PST 
<rdar://problem/87642166>