Bug 235258

Summary: First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Product: WebKit Reporter: Darin Adler <darin>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, bfulgham, cdumez, cfleizach, changseok, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, heycam, jcraig, jdiggs, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, pdr, samuel_white, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
zalan: review+, ews-feeder: commit-queue-
Patch for landing none

Darin Adler
Reported 2022-01-14 16:57:36 PST
First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Attachments
Patch (62.71 KB, patch)
2022-01-14 17:11 PST, Darin Adler 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (63.81 KB, patch)
2022-01-14 17:20 PST, Darin Adler 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (64.67 KB, patch)
2022-01-15 14:01 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2022-01-14 17:11:57 PST Comment hidden (obsolete)
Darin Adler
Comment 2 2022-01-14 17:20:01 PST
Created attachment 449235 [details] Patch
zalan
Comment 3 2022-01-14 18:46:17 PST
Comment on attachment 449235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449235&action=review > Source/WebCore/rendering/RenderReplica.cpp:48 > + // FIXME: Is the comment above obsolete? Can't find a check of isReplacedOrInlineBlock guarding setHasTransform any more. > + setReplacedOrInlineBlock(true); Curious.
Darin Adler
Comment 4 2022-01-15 14:01:05 PST
Created attachment 449269 [details] Patch for landing
Darin Adler
Comment 5 2022-01-15 14:29:35 PST
Committed r288067 (?): <https://commits.webkit.org/r288067>
Radar WebKit Bug Importer
Comment 6 2022-01-15 14:30:18 PST
<rdar://problem/87642166>
Note You need to log in before you can comment on or make changes to this bug.