| Summary: | Share some code that looks at visibility in order to short-circuit repaint rect computation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2022-01-14 11:41:17 PST
Created attachment 449193 [details]
Patch
Comment on attachment 449193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review > Source/WebCore/rendering/RenderObject.cpp:455 > +bool RenderObject::isInsideEntirelyHiddenLayer() const > +{ > + return style().visibility() != Visibility::Visible && !enclosingLayer()->hasVisibleContent(); > +} Does it have to be on RenderObject? Comment on attachment 449193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review >> Source/WebCore/rendering/RenderObject.cpp:455 >> +} > > Does it have to be on RenderObject? Looks like it could be on RenderBox. Will fix. |