Bug 235242

Summary: Share some code that looks at visibility in order to short-circuit repaint rect computation
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Simon Fraser (smfr)
Reported 2022-01-14 11:41:17 PST
Share some code that looks at visibility in order to short-circuit repaint rect computation
Attachments
Patch (7.32 KB, patch)
2022-01-14 11:42 PST, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2022-01-14 11:42:33 PST
Created attachment 449193 [details] Patch
zalan
Comment 2 2022-01-14 12:31:55 PST
Comment on attachment 449193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review > Source/WebCore/rendering/RenderObject.cpp:455 > +bool RenderObject::isInsideEntirelyHiddenLayer() const > +{ > + return style().visibility() != Visibility::Visible && !enclosingLayer()->hasVisibleContent(); > +} Does it have to be on RenderObject?
Simon Fraser (smfr)
Comment 3 2022-01-14 12:35:01 PST
Comment on attachment 449193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review >> Source/WebCore/rendering/RenderObject.cpp:455 >> +} > > Does it have to be on RenderObject? Looks like it could be on RenderBox. Will fix.
Simon Fraser (smfr)
Comment 4 2022-01-15 11:25:34 PST
https://trac.webkit.org/changeset/288060/webkit
Radar WebKit Bug Importer
Comment 5 2022-01-15 11:26:17 PST
<rdar://problem/87640393>
Note You need to log in before you can comment on or make changes to this bug.