Bug 235235

Summary: Use IRC for Wasm, and Briggs for JS on ARM64
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, rmorisset, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ysuzuki: review+
patch for landing none

Description Saam Barati 2022-01-14 10:14:30 PST 
Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit by always using IRC
Comment 1 Saam Barati 2022-01-14 10:15:22 PST 
<rdar://87090631>
Comment 2 Saam Barati 2022-01-14 10:20:31 PST 
(In reply to Saam Barati from comment #0)
> Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit
> by always using IRC

Regressions on iOS on JetStream2
Comment 3 Saam Barati 2022-01-14 10:26:41 PST 
Created attachment 449182 [details]
patch
Comment 4 Yusuke Suzuki 2022-01-14 10:29:06 PST 
Comment on attachment 449182 [details]
patch

r=me
Comment 5 Robin Morisset 2022-01-14 10:32:04 PST 
Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

r=me

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
> +                if (isARM64())

Maybe just return !isArm64(); ?

> Source/JavaScriptCore/b3/air/AirCode.h:416
> +    bool m_forceIRC { false };

It probably does not really matter, but moving it with the other bools would save a word of memory.
Comment 6 Saam Barati 2022-01-14 11:23:28 PST 
Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

>> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
>> +                if (isARM64())
> 
> Maybe just return !isArm64(); ?

as silly as this is, I find the current way slightly easier to read and add new conditions to later.

>> Source/JavaScriptCore/b3/air/AirCode.h:416
>> +    bool m_forceIRC { false };
> 
> It probably does not really matter, but moving it with the other bools would save a word of memory.

will fix
Comment 7 Saam Barati 2022-01-14 11:24:33 PST 
Created attachment 449191 [details]
patch for landing
Comment 8 EWS 2022-01-14 12:06:52 PST 
Committed r288023 (246049@main): <https://commits.webkit.org/246049@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449191 [details].