Bug 235226

Summary: Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235264
Bug Depends on:    
Bug Blocks: 232727    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Kimmo Kinnunen 2022-01-14 04:25:16 PST
Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers
Comment 1 Kimmo Kinnunen 2022-01-14 08:14:31 PST
Created attachment 449173 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-14 08:18:55 PST
<rdar://problem/87601499>
Comment 3 Simon Fraser (smfr) 2022-01-14 08:47:38 PST
Comment on attachment 449173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449173&action=review

> Source/WebKit/Shared/ShareableBitmap.cpp:46
> +    m_handle.takeOwnershipOfMemory(ledger);

Should this assert that m_handle has an m_port already (otherwise the call is a no-op)?
Comment 4 Kimmo Kinnunen 2022-01-14 12:21:56 PST
Created attachment 449202 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-01-15 03:52:44 PST
Created attachment 449251 [details]
Patch
Comment 6 Kimmo Kinnunen 2022-01-15 03:53:43 PST
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 449173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449173&action=review
> 
> > Source/WebKit/Shared/ShareableBitmap.cpp:46
> > +    m_handle.takeOwnershipOfMemory(ledger);
> 
> Should this assert that m_handle has an m_port already (otherwise the call
> is a no-op)?

Logically if ShareableBitmap should assert, so should SharedMemory.
Filed bug 235264 because of apparent existing bugs
Comment 7 EWS 2022-01-17 00:22:34 PST
Committed r288090 (246104@main): <https://commits.webkit.org/246104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449251 [details].