Summary: | Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
Component: | Canvas | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dino, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=235264 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 232727 | ||||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2022-01-14 04:25:16 PST
Created attachment 449173 [details]
Patch
Comment on attachment 449173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449173&action=review > Source/WebKit/Shared/ShareableBitmap.cpp:46 > + m_handle.takeOwnershipOfMemory(ledger); Should this assert that m_handle has an m_port already (otherwise the call is a no-op)? Created attachment 449202 [details]
Patch
Created attachment 449251 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 449173 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449173&action=review > > > Source/WebKit/Shared/ShareableBitmap.cpp:46 > > + m_handle.takeOwnershipOfMemory(ledger); > > Should this assert that m_handle has an m_port already (otherwise the call > is a no-op)? Logically if ShareableBitmap should assert, so should SharedMemory. Filed bug 235264 because of apparent existing bugs Committed r288090 (246104@main): <https://commits.webkit.org/246104@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449251 [details]. |