Summary: | JSStringJoiner's constructor should take a size_t length. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2022-01-13 20:14:08 PST
Created attachment 449131 [details]
proposed patch.
Created attachment 449142 [details]
[fast-cq] patch for landing.
Comment on attachment 449142 [details]
[fast-cq] patch for landing.
Thanks for the review. Landing now.
Committed r288037 (246063@main): <https://commits.webkit.org/246063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449142 [details]. Hi, there is a problem with this test when running with cloop: Running stress/max-typed-array-length-toString.js.default stress/max-typed-array-length-toString.js.default: Exception: FAILED: ReferenceError: Can't find variable: WebAssembly stress/max-typed-array-length-toString.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/max-typed-array-length-toString.js.default Running stress/max-typed-array-length-toString.js.bytecode-cache stress/max-typed-array-length-toString.js.bytecode-cache: Exception: FAILED: ReferenceError: Can't find variable: WebAssembly I think WebAssembly is incompatible with cloop, is that right? Can we skip the test somehow in this case? (In reply to Michael Catanzaro from comment #5) > I think WebAssembly is incompatible with cloop, is that right? Can we skip > the test somehow in this case? Fixed in r288120: <http://trac.webkit.org/r288120>. Thanks Mark! The test is actually still failing: Crashing because current footprint: 637390848 exceeds limit: 629145600 I will skip it if memory limited. Reopening to attach new patch. Created attachment 449483 [details]
Patch for landing
Committed r288213 (246174@main): <https://commits.webkit.org/246174@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449483 [details]. |