Bug 235201

Summary: Link Wasm code on the same thread that JITs
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235192    
Attachments:
Description Flags
patch
ysuzuki: review+
patch for landing none

Saam Barati
Reported 2022-01-13 13:46:29 PST
...
Attachments
patch (10.17 KB, patch)
2022-01-13 14:42 PST, Saam Barati 		ysuzuki: review+
DetailsFormatted DiffDiff
patch for landing (10.12 KB, patch)
2022-01-13 15:14 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-13 14:04:56 PST
THAT IS AWESOME!!!!!!!
Saam Barati
Comment 2 2022-01-13 14:42:20 PST
Created attachment 449114 [details] patch
Yusuke Suzuki
Comment 3 2022-01-13 14:56:00 PST
Comment on attachment 449114 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=449114&action=review r=me > Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:201 > + auto result = m_embedderToWasmInternalFunctions.add(functionIndex, std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>> { WTFMove(linkBuffer), WTFMove(embedderToWasmInternalFunction) }); I think you can use `std::pair { ... }` instead of `std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>>`.
Mark Lam
Comment 4 2022-01-13 14:59:06 PST
Comment on attachment 449114 [details] patch r=me too.
Saam Barati
Comment 5 2022-01-13 15:14:23 PST
Comment on attachment 449114 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=449114&action=review >> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:201 >> + auto result = m_embedderToWasmInternalFunctions.add(functionIndex, std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>> { WTFMove(linkBuffer), WTFMove(embedderToWasmInternalFunction) }); > > I think you can use `std::pair { ... }` instead of `std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>>`. Nice. I didn't know that. I first tried just "{ ... }", but that failed, so I went with the full type declaration. Will fix.
Saam Barati
Comment 6 2022-01-13 15:14:56 PST
Created attachment 449118 [details] patch for landing
EWS
Comment 7 2022-01-13 18:41:16 PST
Committed r288002 (246028@main): <https://commits.webkit.org/246028@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449118 [details].
Radar WebKit Bug Importer
Comment 8 2022-01-13 18:42:16 PST
<rdar://problem/87582343>
Note You need to log in before you can comment on or make changes to this bug.