Summary: | Avoid unnecessary call to windowScreenDidChange | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, ggaren, graouts, simon.fraser, slewis, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Per Arne Vollan
2022-01-13 13:32:06 PST
Created attachment 449098 [details]
Patch
Comment on attachment 449098 [details]
Patch
r=me
This is a great fix for a regression in trunk.
Having fixed the regression, I'm concerned that we've got a ticking time bomb that will regress again when we enable WebAnimationsCustomFrameRate by default. What should we do about that?
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 449098 [details] > Patch > > r=me > > This is a great fix for a regression in trunk. > > Having fixed the regression, I'm concerned that we've got a ticking time > bomb that will regress again when we enable WebAnimationsCustomFrameRate by > default. What should we do about that? I can create a new bug for that. Thanks for reviewing! Committed r287995 (246022@main): <https://commits.webkit.org/246022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449098 [details]. |