Bug 235198

Summary: Avoid unnecessary call to windowScreenDidChange
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ggaren, graouts, simon.fraser, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2022-01-13 13:32:06 PST 
It is a page load performance progression to avoid this call.
Comment 1 Per Arne Vollan 2022-01-13 13:33:22 PST 
<rdar://87458502>
Comment 2 Per Arne Vollan 2022-01-13 13:34:40 PST 
Created attachment 449098 [details]
Patch
Comment 3 Geoffrey Garen 2022-01-13 13:44:01 PST 
Comment on attachment 449098 [details]
Patch

r=me

This is a great fix for a regression in trunk.

Having fixed the regression, I'm concerned that we've got a ticking time bomb that will regress again when we enable WebAnimationsCustomFrameRate by default. What should we do about that?
Comment 4 Per Arne Vollan 2022-01-13 13:50:03 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 449098 [details]
> Patch
> 
> r=me
> 
> This is a great fix for a regression in trunk.
> 
> Having fixed the regression, I'm concerned that we've got a ticking time
> bomb that will regress again when we enable WebAnimationsCustomFrameRate by
> default. What should we do about that?

I can create a new bug for that.

Thanks for reviewing!
Comment 5 EWS 2022-01-13 15:05:12 PST 
Committed r287995 (246022@main): <https://commits.webkit.org/246022@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449098 [details].