Bug 235191

Summary: Expose way to encode CTAP commands with only hash of ClientDataJSON
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

pascoe@apple.com
Reported 2022-01-13 10:27:10 PST
_WKWebAuthenticationPanel should expose a way to encode CTAP commands with only the hash of ClientDataJSON, as the full value isn't necessary and isn't always available.
Attachments
Patch (4.80 KB, patch)
2022-01-13 10:33 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Patch (8.97 KB, patch)
2022-01-13 14:17 PST, pascoe@apple.com 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-13 10:27:21 PST
<rdar://problem/87557846>
pascoe@apple.com
Comment 2 2022-01-13 10:33:53 PST
Created attachment 449083 [details] Patch
Brent Fulgham
Comment 3 2022-01-13 13:08:05 PST
Comment on attachment 449083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review > Source/WebKit/ChangeLog:9 > + CTAP command encoding covered by existing tests. Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands?
Brent Fulgham
Comment 4 2022-01-13 14:11:53 PST
Comment on attachment 449083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review >> Source/WebKit/ChangeLog:9 >> + CTAP command encoding covered by existing tests. > > Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands? I spoke with Pascoe about this, and he will ensure proper testing is available in follow-up work.
pascoe@apple.com
Comment 5 2022-01-13 14:17:04 PST
Created attachment 449109 [details] Patch
Brent Fulgham
Comment 6 2022-01-13 15:10:08 PST
Comment on attachment 449109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449109&action=review r=me > Tools/ChangeLog:3 > + Expose way to encode CTAP commands with only the hash of ClientDataJSON Thank you for adding a test!
EWS
Comment 7 2022-01-14 00:03:25 PST
Committed r288010 (246036@main): <https://commits.webkit.org/246036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449109 [details].
Note You need to log in before you can comment on or make changes to this bug.