Bug 235179

Summary: Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ews-watchlist, hi, japhet, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing ews-feeder: commit-queue-

youenn fablet
Reported 2022-01-13 05:01:51 PST
Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents
Attachments
Patch (40.05 KB, patch)
2022-01-13 05:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (42.07 KB, patch)
2022-01-13 11:08 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (41.98 KB, patch)
2022-01-16 22:26 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (42.64 KB, patch)
2022-01-16 22:27 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2022-01-13 05:06:01 PST
Created attachment 449049 [details] Patch
youenn fablet
Comment 2 2022-01-13 11:08:12 PST
Created attachment 449086 [details] Patch
Darin Adler
Comment 3 2022-01-14 10:24:08 PST
Comment on attachment 449086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449086&action=review Assuming there is no performance problem with this additional IPC > Source/WebCore/Modules/fetch/FetchResponse.h:123 > + void setNetworkLoadMetrics(const NetworkLoadMetrics& networkLoadMetrics) { m_networkLoadMetrics = networkLoadMetrics; } Would have named the argument just metrics. > Source/WebCore/loader/WorkerThreadableLoader.cpp:243 > +void WorkerThreadableLoader::MainThreadBridge::didFinishLoading(ResourceLoaderIdentifier identifier, const NetworkLoadMetrics& networkLoadMetrics) Here too.
youenn fablet
Comment 4 2022-01-16 22:26:35 PST
Created attachment 449306 [details] Patch for landing
youenn fablet
Comment 5 2022-01-16 22:27:47 PST
Created attachment 449307 [details] Patch for landing
EWS
Comment 6 2022-01-17 00:05:40 PST
Committed r288088 (246102@main): <https://commits.webkit.org/246102@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449307 [details].
Radar WebKit Bug Importer
Comment 7 2022-01-17 00:06:20 PST
<rdar://problem/87668830>
Note You need to log in before you can comment on or make changes to this bug.