Summary: | Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, darin, ews-watchlist, hi, japhet, joepeck, pangle, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2022-01-13 05:01:51 PST
Created attachment 449049 [details]
Patch
Created attachment 449086 [details]
Patch
Comment on attachment 449086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449086&action=review Assuming there is no performance problem with this additional IPC > Source/WebCore/Modules/fetch/FetchResponse.h:123 > + void setNetworkLoadMetrics(const NetworkLoadMetrics& networkLoadMetrics) { m_networkLoadMetrics = networkLoadMetrics; } Would have named the argument just metrics. > Source/WebCore/loader/WorkerThreadableLoader.cpp:243 > +void WorkerThreadableLoader::MainThreadBridge::didFinishLoading(ResourceLoaderIdentifier identifier, const NetworkLoadMetrics& networkLoadMetrics) Here too. Created attachment 449306 [details]
Patch for landing
Created attachment 449307 [details]
Patch for landing
Committed r288088 (246102@main): <https://commits.webkit.org/246102@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449307 [details]. |