Summary: | Add to Contact menu item does nothing on mac. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | thorton, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Megan Gardner
2022-01-12 13:51:18 PST
Created attachment 448993 [details]
Patch
Comment on attachment 448993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448993&action=review Please make sure there's a bug tracking adopting TextIndicator here instead of just hiding the highlight. > Source/WebKit/UIProcess/PageClient.h:436 > + virtual NSView *activeView() const = 0; In order to make this less tempting, maybe we can call it viewForPresentingRevealPopover? > Source/WebKit/UIProcess/mac/PageClientImplMac.h:230 > - NSView *activeView() const; > + NSView *activeView() const override; And then here in the mac impl you'll just turn around and call activeView... Created attachment 449003 [details]
Patch for landing
Committed r287959 (245988@main): <https://commits.webkit.org/245988@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449003 [details]. |