Bug 235154

Summary: Add to Contact menu item does nothing on mac.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Megan Gardner 2022-01-12 13:51:18 PST
Add to Contact menu item does nothing on mac.
Comment 1 Megan Gardner 2022-01-12 13:54:20 PST
Comment 2 Megan Gardner 2022-01-12 13:57:57 PST
Created attachment 448993 [details]
Comment 3 Tim Horton 2022-01-12 14:02:31 PST
Comment on attachment 448993 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=448993&action=review

Please make sure there's a bug tracking adopting TextIndicator here instead of just hiding the highlight.

> Source/WebKit/UIProcess/PageClient.h:436
> +    virtual NSView *activeView() const = 0;

In order to make this less tempting, maybe we can call it viewForPresentingRevealPopover?

> Source/WebKit/UIProcess/mac/PageClientImplMac.h:230
> -    NSView *activeView() const;
> +    NSView *activeView() const override;

And then here in the mac impl you'll just turn around and call activeView...
Comment 4 Megan Gardner 2022-01-12 15:12:14 PST
Created attachment 449003 [details]
Patch for landing
Comment 5 EWS 2022-01-12 16:01:27 PST
Committed r287959 (245988@main): <https://commits.webkit.org/245988@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449003 [details].