Bug 235154

Summary: Add to Contact menu item does nothing on mac.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-01-12 13:51:18 PST
Add to Contact menu item does nothing on mac.
Attachments
Patch (14.81 KB, patch)
2022-01-12 13:57 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.91 KB, patch)
2022-01-12 15:12 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-01-12 13:54:20 PST
rdar://80213097
Megan Gardner
Comment 2 2022-01-12 13:57:57 PST
Created attachment 448993 [details] Patch
Tim Horton
Comment 3 2022-01-12 14:02:31 PST
Comment on attachment 448993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448993&action=review Please make sure there's a bug tracking adopting TextIndicator here instead of just hiding the highlight. > Source/WebKit/UIProcess/PageClient.h:436 > + virtual NSView *activeView() const = 0; In order to make this less tempting, maybe we can call it viewForPresentingRevealPopover? > Source/WebKit/UIProcess/mac/PageClientImplMac.h:230 > - NSView *activeView() const; > + NSView *activeView() const override; And then here in the mac impl you'll just turn around and call activeView...
Megan Gardner
Comment 4 2022-01-12 15:12:14 PST
Created attachment 449003 [details] Patch for landing
EWS
Comment 5 2022-01-12 16:01:27 PST
Committed r287959 (245988@main): <https://commits.webkit.org/245988@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449003 [details].
Note You need to log in before you can comment on or make changes to this bug.