Bug 23513
| Summary: | Rename some animation-related methods for clarity | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Chris Marrin <cmarrin> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Simon Fraser (smfr)
In Animation:
bool direction() const { return m_direction; }
This needs to have an enum.
int iterationCount() const { return m_iterationCount; }
This needs a constant for the magic "-1" value.
In AnimationBase:
virtual double willNeedService();
"willNeedService" sounds like it returns a bool, but it does not.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
*** This bug has been marked as a duplicate of 23188 ***