Bug 235128

Summary: Clean up MediaPlaybackTargetPicker::Client
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: MediaAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch none

Description Peng Liu 2022-01-12 11:44:53 PST 
Clean up MediaPlaybackTargetPicker::Client
Comment 1 Peng Liu 2022-01-12 11:48:43 PST 
Created attachment 448980 [details]
[fast-cq] Patch
Comment 2 Eric Carlson 2022-01-12 11:57:59 PST 
Comment on attachment 448980 [details]
[fast-cq] Patch

Can you also make the class `final`?
Comment 3 Peng Liu 2022-01-12 12:22:17 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 448980 [details]
> Patch
> 
> Can you also make the class `final`?

Do you mean class `WebMediaSessionManager`? It is the base class of `WebMediaSessionManagerMac`, so we cannot make it `final`.
Comment 4 EWS 2022-01-13 09:17:22 PST 
Committed r287980 (246009@main): <https://commits.webkit.org/246009@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448980 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-13 09:18:19 PST 
<rdar://problem/87553166>