Bug 23511

Summary: Move DOMTimer from WebCore/bindings/js to WebCore/page
Product: WebKit Reporter: Dmitry Titov <dimich>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric, fishd, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to move the file
none
Updated patch ap: review+

Dmitry Titov
Reported 2009-01-23 17:52:07 PST
DOMTimer, after recent refactoring, does not have any JSC code and is in fact a dom object (derived from ActiveDOMObject). This also will help eliminate the forked version in Chromium.
Attachments
Patch to move the file (29.04 KB, patch)
2009-01-23 17:58 PST, Dmitry Titov 		no flags
DetailsFormatted DiffDiff
Updated patch (29.10 KB, patch)
2009-01-26 11:41 PST, Dmitry Titov 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-01-23 17:58:43 PST
Created attachment 26990 [details] Patch to move the file Decided to do it in 2 patches, to keep svn history nice. First patch - only moves the file. Second patch will also make Chromium will compile after the next merge.
Dmitry Titov
Comment 2 2009-01-23 18:14:25 PST
In fact, there is nothing else needed except the patch that's attached. The next merge will auto-unfork dom/DOMTimer.h :-)
Alexey Proskuryakov
Comment 3 2009-01-26 00:34:51 PST
If I'm not mistaken, WebCore/dom is actually for DOM Core classes, so DOMTimer should go to WebCore/page. Sam, is this correct?
Sam Weinig
Comment 4 2009-01-26 08:05:53 PST
Yes, page/ would be better.
Dmitry Titov
Comment 5 2009-01-26 11:41:50 PST
Created attachment 27042 [details] Updated patch Changed from dom/ to page/
Alexey Proskuryakov
Comment 6 2009-01-26 11:59:47 PST
Comment on attachment 27042 [details] Updated patch r=me
Dmitry Titov
Comment 7 2009-01-26 17:03:26 PST
Landed in r40271
Note You need to log in before you can comment on or make changes to this bug.