| Summary: | [css-flexbox] Import WPT tests - January edition | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, clopez, ews-watchlist, mrobinson, rbuis, rego, simon.fraser, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 234564 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sergio Villar Senin
2022-01-12 02:28:24 PST
Created attachment 448918 [details]
Patch
Comment on attachment 448918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448918&action=review > LayoutTests/imported/w3c/resources/resource-files.json:22 > + "css/css-flexbox/abspos/flex-abspos-staticpos-align-self-safe-001-ref.html", Mmmm, there are a lot of -ref files here, but they're actually not being imported. Maybe you forgot to git add them. The problem is that since r287267 we're importing the -ref.html files, and also creating copies as -expected.html. So we end up having duplicates. I'm not sure what's the best solution, but one option is to revert that patch to run the import script, and generate a patch that doesn't add so many -ref. Other option might be to merge duplicated files (like it has already happened in some folders). See this comment https://bugs.webkit.org/show_bug.cgi?id=203784#c27 for more info. Created attachment 448930 [details]
Patch
Comment on attachment 448930 [details]
Patch
r=me
Committed r287927 (?): <https://commits.webkit.org/r287927> |