Bug 23509

Summary:

Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch to stop a crasher	bdakin: review+
new patch based on review	darin: review+

chris fleizach

Reported 2009-01-23 14:40:33 PST

WebKit can crash at this position when startOfLine returns null

Attachments
patch to stop a crasher (2.49 KB, patch) 2009-01-23 14:42 PST, chris fleizach	bdakin: review+	Details Formatted Diff Diff
new patch based on review (3.13 KB, patch) 2009-01-23 16:23 PST, chris fleizach	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2009-01-23 14:42:01 PST

Created attachment 26984 [details] patch to stop a crasher

chris fleizach

Comment 2 2009-01-23 14:42:56 PST

no good steps to reproduce listed in the bug, but the backtrace is pretty clear as to what's happening. as a result, i could not devise a layout test to that elicited the crash

chris fleizach

Comment 3 2009-01-23 15:03:44 PST

http://trac.webkit.org/changeset/40191

Darin Adler

Comment 4 2009-01-23 16:12:35 PST

Comment on attachment 26984 [details] patch to stop a crasher Seems to me that makeRange should probably return 0 if passed null positions. And plainText already handles the case where the range is 0. So I would suggest fixing this in the makeRange function rather than in the AccessibilityObject class.

chris fleizach

Comment 5 2009-01-23 16:23:47 PST

Created attachment 26987 [details] new patch based on review

chris fleizach

Comment 6 2009-01-23 16:24:12 PST

updated patch based on Darin's review

chris fleizach

Comment 7 2009-01-23 16:24:48 PST

Darin, is this what you had in mind (In reply to comment #4) > (From update of attachment 26984 [details] [review]) > Seems to me that makeRange should probably return 0 if passed null positions. > And plainText already handles the case where the range is 0. So I would suggest > fixing this in the makeRange function rather than in the AccessibilityObject > class. >

Darin Adler

Comment 8 2009-01-23 17:18:02 PST

Comment on attachment 26987 [details] new patch based on review r=me

chris fleizach

Comment 9 2009-01-23 17:21:52 PST

http://trac.webkit.org/changeset/40202

Note You need to log in before you can comment on or make changes to this bug.