| Summary: | WebPageProxy destruction should not launch a network process | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, sihui_liu, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Geoffrey Garen
2022-01-11 15:18:42 PST
Created attachment 448883 [details]
Patch
Comment on attachment 448883 [details]
Patch
This is not a bad idea. It can be tested by extending the NetworkProcess.LaunchOnlyWhenNecessary API test.
Created attachment 448890 [details]
Patch
Comment on attachment 448890 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448890&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:95 > + webView = nullptr; Does this destroy the WebPageProxy? I would expect an @autoreleasepool somewhere to prevent any autoreleased objects from keeping it alive. Created attachment 448892 [details]
Patch
Committed r287907 (245940@main): <https://commits.webkit.org/245940@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448892 [details]. |