Bug 235081

Summary: Update hashThreadState() to exclude __opaque_flags.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235156    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2022-01-11 12:53:52 PST
Also remove some unused code. rdar://86282584
Attachments
proposed patch. (10.29 KB, patch)
2022-01-11 13:32 PST, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-01-11 13:32:23 PST
Created attachment 448875 [details] proposed patch.
Keith Miller
Comment 2 2022-01-11 13:43:20 PST
Comment on attachment 448875 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=448875&action=review > Source/WTF/wtf/threads/Signals.cpp:175 > + // Exclude the __opaque_flags field which is reserved for OS use. Nit: Maybe say that __opaque_flags is at the end of the payload.
Mark Lam
Comment 3 2022-01-11 20:04:41 PST
(In reply to Keith Miller from comment #2) > Nit: Maybe say that __opaque_flags is at the end of the payload. Thanks for the review. I've added the comment. Landed in r287908: <http://trac.webkit.org/r287908>.
WebKit Commit Bot
Comment 4 2022-01-12 13:52:36 PST
Re-opened since this is blocked by bug 235156
Mark Lam
Comment 5 2022-01-12 16:37:50 PST
Re-landed in r287961: <http://trac.webkit.org/r287961>.
Note You need to log in before you can comment on or make changes to this bug.