Bug 235060

Summary: [CSS contain] Update css-contain tests from WPT
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, rego, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2022-01-11 02:08:05 PST
[CSS contain] Update css-contain tests from WPT
Attachments
Patch (119.07 KB, patch)
2022-01-11 02:15 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (335.31 KB, patch)
2022-01-11 02:24 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (140.89 KB, patch)
2022-01-11 07:23 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-01-11 02:15:17 PST
Created attachment 448833 [details] Patch
Rob Buis
Comment 2 2022-01-11 02:24:52 PST
Created attachment 448834 [details] Patch
Manuel Rego Casasnovas
Comment 3 2022-01-11 03:25:04 PST
Comment on attachment 448834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review > LayoutTests/imported/w3c/ChangeLog:11 > + This also changes many test expectations to expect PASSes instead of FAILs. Since they > + actually fail these need to be skipped for now. Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches. If we just skip tests, we are going to detect that we improve anything, unless we unskip them.
Manuel Rego Casasnovas
Comment 4 2022-01-11 03:38:19 PST
Comment on attachment 448834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review > LayoutTests/imported/w3c/ChangeLog:15 > + * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-expected.html: Added. > + * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added. These 2 files are duplicated? It seems we have some problem in the import script.
Rob Buis
Comment 5 2022-01-11 07:23:53 PST
Created attachment 448846 [details] Patch
Rob Buis
Comment 6 2022-01-11 07:54:05 PST
Comment on attachment 448834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review >> LayoutTests/imported/w3c/ChangeLog:11 >> + actually fail these need to be skipped for now. > > Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches. > > If we just skip tests, we are going to detect that we improve anything, unless we unskip them. Not common, I removed it in the new patch. >> LayoutTests/imported/w3c/ChangeLog:15 >> + * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added. > > These 2 files are duplicated? It seems we have some problem in the import script. Right, this is behaviour since https://bugs.webkit.org/show_bug.cgi?id=234510 landed. On advice of ntim I reverted it locally, so the new patch has no -ref files anymore.
Manuel Rego Casasnovas
Comment 7 2022-01-11 08:21:41 PST
Comment on attachment 448846 [details] Patch r=me, thanks.
EWS
Comment 8 2022-01-11 09:44:21 PST
Committed r287882 (245926@main): <https://commits.webkit.org/245926@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448846 [details].
Radar WebKit Bug Importer
Comment 9 2022-01-11 09:45:17 PST
<rdar://problem/87404377>
Note You need to log in before you can comment on or make changes to this bug.