Bug 23506

Summary: Upstream chromium's image decoders
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch: part 1 - copy existing files
eric: review+
patch: part 2 - copy ImageDecoder.h as well
eric: review+
patch: part 3 - apply skia changes on top eric: review+

Darin Fisher (:fishd, Google)
Reported 2009-01-23 10:39:45 PST
Upstream chromium's image decoders From here: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/image-decoders/skia/ My plan is to attach two patches. The first will copy the existing PNG, JPEG, and GIF decoders. Then, I will do a subsequent change, which applies our changes as well as adds BMP, ICO, and XBM decoders.
Attachments
patch: part 1 - copy existing files (100.24 KB, patch)
2009-01-23 10:41 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
patch: part 2 - copy ImageDecoder.h as well (8.29 KB, patch)
2009-01-23 10:55 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
patch: part 3 - apply skia changes on top (148.90 KB, patch)
2009-01-23 10:59 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-01-23 10:41:02 PST
Created attachment 26975 [details] patch: part 1 - copy existing files
Eric Seidel (no email)
Comment 2 2009-01-23 10:43:23 PST
Comment on attachment 26975 [details] patch: part 1 - copy existing files rs=me
Darin Fisher (:fishd, Google)
Comment 3 2009-01-23 10:55:56 PST
Created attachment 26976 [details] patch: part 2 - copy ImageDecoder.h as well
Darin Fisher (:fishd, Google)
Comment 4 2009-01-23 10:59:23 PST
Created attachment 26977 [details] patch: part 3 - apply skia changes on top
Eric Seidel (no email)
Comment 5 2009-01-23 11:20:03 PST
Comment on attachment 26976 [details] patch: part 2 - copy ImageDecoder.h as well rs=me
Eric Seidel (no email)
Comment 6 2009-01-23 11:21:55 PST
Comment on attachment 26977 [details] patch: part 3 - apply skia changes on top This is a bit hard to review at this size. It is possible to split out the adds into a new patch? Or somehow make this one smaller?
Eric Seidel (no email)
Comment 7 2009-01-23 12:26:31 PST
Comment on attachment 26977 [details] patch: part 3 - apply skia changes on top Gonna rubber stamp this. I've reviewed this already when you submitted it to our local branch. My understanding of the "grand plan" is that Hyatt was interested in replacing the shared decoders with Chromium's decoders. Peter Kasting intends to take care of that merging/replacement work.
Note You need to log in before you can comment on or make changes to this bug.