Bug 235041

Summary: Remove AppleTV specific disabling of conic gradients, its not necessary
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2022-01-10 11:22:06 PST
Remove AppleTV specific disabling of conic gradients, its not necessary
Attachments
Patch (3.16 KB, patch)
2022-01-10 11:23 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2022-01-10 17:44 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (4.37 KB, patch)
2022-01-11 06:31 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2022-01-10 11:23:35 PST
Created attachment 448780 [details] Patch
Darin Adler
Comment 2 2022-01-10 15:00:33 PST
Comment on attachment 448780 [details] Patch Did I wrote those FIXMEs? Sounds like me. What about the closely related tvOS exception for ENABLE_CSS_CONIC_GRADIENTS in PlatformEnableCocoa.h? (also ENABLE_MONOSPACE_FONT_EXCEPTION is likely a similar mistake)
Sam Weinig
Comment 3 2022-01-10 17:44:49 PST
Created attachment 448819 [details] Patch
Sam Weinig
Comment 4 2022-01-10 17:46:45 PST
Since the last patch broke windows, this new one keeps the conditional but makes it a HAVE and then bases ENABLE_CSS_CONIC_GRADIENTS on that HAVE. Does this look good to you?
Darin Adler
Comment 5 2022-01-10 18:08:25 PST
Comment on attachment 448819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448819&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:182 > +#if !defined(ENABLE_CSS_CONIC_GRADIENTS) && HAVE(CORE_GRAPHICS_CONIC_GRADIENTS) Since this is a Cocoa-only file, you could omit the HAVE() call here.
Sam Weinig
Comment 6 2022-01-11 06:31:04 PST
Created attachment 448842 [details] Patch
EWS
Comment 7 2022-01-11 07:42:24 PST
Committed r287879 (245923@main): <https://commits.webkit.org/245923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448842 [details].
Radar WebKit Bug Importer
Comment 8 2022-01-11 07:43:16 PST
<rdar://problem/87397803>
Note You need to log in before you can comment on or make changes to this bug.