| Summary: | Remove AppleTV specific disabling of conic gradients, its not necessary | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2022-01-10 11:22:06 PST
Created attachment 448780 [details]
Patch
Comment on attachment 448780 [details]
Patch
Did I wrote those FIXMEs? Sounds like me.
What about the closely related tvOS exception for ENABLE_CSS_CONIC_GRADIENTS in PlatformEnableCocoa.h? (also ENABLE_MONOSPACE_FONT_EXCEPTION is likely a similar mistake)
Created attachment 448819 [details]
Patch
Since the last patch broke windows, this new one keeps the conditional but makes it a HAVE and then bases ENABLE_CSS_CONIC_GRADIENTS on that HAVE. Does this look good to you? Comment on attachment 448819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448819&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:182 > +#if !defined(ENABLE_CSS_CONIC_GRADIENTS) && HAVE(CORE_GRAPHICS_CONIC_GRADIENTS) Since this is a Cocoa-only file, you could omit the HAVE() call here. Created attachment 448842 [details]
Patch
Committed r287879 (245923@main): <https://commits.webkit.org/245923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448842 [details]. |