| Summary: | Modal container observer should classify elements that are styled like clickable controls | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | akeerthi, bdakin, megan_gardner, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2022-01-09 15:46:16 PST
Created attachment 448772 [details]
Patch
Comment on attachment 448772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448772&action=review > Source/WebCore/page/ModalContainerObserver.cpp:300 > +static bool listensForUserActivation(const Element& element) This seems like a handy thing, I'm surprised it's unique to this code. (In reply to Tim Horton from comment #2) > Comment on attachment 448772 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448772&action=review > > > Source/WebCore/page/ModalContainerObserver.cpp:300 > > +static bool listensForUserActivation(const Element& element) > > This seems like a handy thing, I'm surprised it's unique to this code. True! I suppose it is similar to the list in `Node::willRespondToMouseClickEvents()`, but with the addition of some pointer and touch events (and without the editability check). I could imagine moving it to somewhere like `Node` in the future, if more things outside of ModalContainerObserver find it useful... Committed r287860 (245904@main): <https://commits.webkit.org/245904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448772 [details]. |