Bug 235022

Summary: Modal container observer should classify elements that are styled like clickable controls
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, bdakin, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Wenson Hsieh
Reported 2022-01-09 15:46:16 PST
.
Attachments
Patch (8.37 KB, patch)
2022-01-10 10:42 PST, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-01-10 10:42:26 PST
Created attachment 448772 [details] Patch
Tim Horton
Comment 2 2022-01-10 12:58:12 PST
Comment on attachment 448772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448772&action=review > Source/WebCore/page/ModalContainerObserver.cpp:300 > +static bool listensForUserActivation(const Element& element) This seems like a handy thing, I'm surprised it's unique to this code.
Wenson Hsieh
Comment 3 2022-01-10 13:09:53 PST
(In reply to Tim Horton from comment #2) > Comment on attachment 448772 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=448772&action=review > > > Source/WebCore/page/ModalContainerObserver.cpp:300 > > +static bool listensForUserActivation(const Element& element) > > This seems like a handy thing, I'm surprised it's unique to this code. True! I suppose it is similar to the list in `Node::willRespondToMouseClickEvents()`, but with the addition of some pointer and touch events (and without the editability check). I could imagine moving it to somewhere like `Node` in the future, if more things outside of ModalContainerObserver find it useful...
EWS
Comment 4 2022-01-10 15:00:03 PST
Committed r287860 (245904@main): <https://commits.webkit.org/245904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448772 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-10 15:01:16 PST
<rdar://problem/87364047>
Note You need to log in before you can comment on or make changes to this bug.